[webkit-reviews] review granted: [Bug 134121] [New Multicolumn] Writing mode and direction of flow thread can mismatch enclosing paginated RenderView : [Attachment 233617] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 23 11:34:17 PDT 2014
Dean Jackson <dino at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 134121: [New Multicolumn] Writing mode and direction of flow thread can
mismatch enclosing paginated RenderView
https://bugs.webkit.org/show_bug.cgi?id=134121
Attachment 233617: Patch
https://bugs.webkit.org/attachment.cgi?id=233617&action=review
------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233617&action=review
> Source/WebCore/rendering/RenderBox.cpp:372
> + RenderObject* rootRenderer = isBodyRenderer ?
document().documentElement()->renderer() : nullptr;
Slightly risky that someone will move rootRenderer outside the isBodyRenderer
blocks below, but hopefully no one will be that careless ($10 that it will be
me in 4 years time).
More information about the webkit-reviews
mailing list