[webkit-reviews] review granted: [Bug 131487] [GTK] Windowed plugins visibility doesn't work : [Attachment 229124] Try to fix EFL and mac builds

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 23 09:37:19 PDT 2014

Anders Carlsson <andersca at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 131487: [GTK] Windowed plugins visibility doesn't work

Attachment 229124: Try to fix EFL and mac builds

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229124&action=review

> Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:428
> +void PluginControllerProxy::visibilityDidChange(bool visible)

Please name the parameter isVisible.

> Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:619
> +void PluginControllerProxy::windowedPluginVisibilityDidChange(bool visible,
uint64_t windowID)

Please name the parameter isVisible, and I think it makes more sense to put the
windowID first.

> Source/WebKit2/WebProcess/Plugins/PluginView.cpp:1021
> +    if (isParentVisible() == visible)
> +	   return;

I think you still want to call the Widget implementation.

More information about the webkit-reviews mailing list