[webkit-reviews] review denied: [Bug 134184] Elements with rendering disabled due to dimensions should not contribute to parent bounding box : [Attachment 233585] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Nikos Andronikos
<nikos.andronikos-webkit at cisra.canon.com.au>'s request for review:
Bug 134184: Elements with rendering disabled due to dimensions should not
contribute to parent bounding box
https://bugs.webkit.org/show_bug.cgi?id=134184

Attachment 233585: Patch
https://bugs.webkit.org/attachment.cgi?id=233585&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=233585&action=review


> Source/WebCore/rendering/svg/RenderSVGPath.cpp:164
> +    return m_fillBoundingBox.isEmpty();

Don't think that this is correct: M20,20,L20,20z is a valid path and has a
bounding box of 20,20,0,0. Maybe check if the created Path is empty?

> Source/WebCore/rendering/svg/RenderSVGShape.h:70
> +	   // returning false by default ensures backwards compatibility for

s/returning/Returning/

> LayoutTests/ChangeLog:9
> +	   Test, for each element type, that when rendering is disabled, that
element does not contribute
> +	   to the bounding box for an ancestor element.

Could you write W3C tests that can then be committed to the W3C in parallel
please?

http://testthewebforward.org/docs/testharness-tutorial.html