[webkit-reviews] review granted: [Bug 134183] [iOS] Use WebGLLayer rather than PlatformLayer in GraphicsContext3D : [Attachment 233583] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jun 22 22:42:14 PDT 2014
Sam Weinig <sam at webkit.org> has granted Dean Jackson <dino at apple.com>'s request
for review:
Bug 134183: [iOS] Use WebGLLayer rather than PlatformLayer in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=134183
Attachment 233583: Patch
https://bugs.webkit.org/attachment.cgi?id=233583&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=233583&action=review
> Source/WebCore/ChangeLog:13
> + * platform/graphics/GraphicsContext3D.h: Replace
RefPtr<PlatformLayer>
> + with RefPtr<WebGLLayer>.
RetainPtr, not RefPtr.
> Source/WebCore/platform/graphics/GraphicsContext3D.h:1010
> #if PLATFORM(IOS)
> PlatformGraphicsContext3D m_contextObj;
> - RetainPtr<PlatformLayer> m_webGLLayer;
> + RetainPtr<WebGLLayer> m_webGLLayer;
> #elif PLATFORM(MAC)
> CGLContextObj m_contextObj;
> RetainPtr<WebGLLayer> m_webGLLayer;
Can this just be turned into PLATFORM(COCOA)?
More information about the webkit-reviews
mailing list