[webkit-reviews] review granted: [Bug 134179] [Apple] WebGL layer may use GC3D after free with remote layer hosting : [Attachment 233580] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 134179: [Apple] WebGL layer may use GC3D after free with remote layer
hosting
https://bugs.webkit.org/show_bug.cgi?id=134179

Attachment 233580: Patch
https://bugs.webkit.org/attachment.cgi?id=233580&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233580&action=review


> Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:335
> +	   [m_webGLLayer.get() setContext:nullptr];

no .get() required!

> Source/WebCore/platform/graphics/mac/WebGLLayer.mm:45
> + at synthesize context=m_context;

ObjC members don't usually have an 'm_' prefix, just '_'. (I see this predates
your changes, though).