[webkit-reviews] review denied: [Bug 134165] Add skeleton code for updated Gamepad API : [Attachment 233548] Patch v2 - Try to get GTK/EFL builds to not be trying to build this stuff.

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Brady Eidson <beidson at apple.com>'s
request for review:
Bug 134165: Add skeleton code for updated Gamepad API
https://bugs.webkit.org/show_bug.cgi?id=134165

Attachment 233548: Patch v2 - Try to get GTK/EFL builds to not be trying to
build this stuff.
https://bugs.webkit.org/attachment.cgi?id=233548&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=233548&action=review


> Source/WebCore/Modules/gamepad/Gamepad.h:64
> +    Vector<RefPtr<GamepadButton>> m_buttons;

Can this be a Vector<Ref<GamepadButton>>?

> Source/WebCore/Modules/gamepad/Gamepad.idl:27
> +    NoInterfaceObject,

Why NoInterfaceObject?

> Source/WebCore/Modules/gamepad/GamepadButton.idl:27
> +    NoInterfaceObject,

Why NoInterfaceObject?

> Source/WebCore/Modules/gamepad/GamepadEvent.h:40
> +    };

Misplaced ;

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:1613
> -		498770E91242C535002226BA /* Shader.h in Headers */ = {isa =
PBXBuildFile; fileRef = 498770D01242C535002226BA /* Shader.h */; };
> +		498770E91242C535002226BA /* (null) in Headers */ = {isa =
PBXBuildFile; };

This looks wrong.