[webkit-reviews] review granted: [Bug 134166] Implement the rest of back forward tree decoding : [Attachment 233550] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 134166: Implement the rest of back forward tree decoding
https://bugs.webkit.org/show_bug.cgi?id=134166

Attachment 233550: Patch
https://bugs.webkit.org/attachment.cgi?id=233550&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=233550&action=review


> Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:445
> +	   decoder >> formDataElement.fileStart;
> +	   if (formDataElement.fileStart < 0)
> +	       return;

Is formDataElement.fileStart < 0 ever ok? Should this mark the decoder as
invalid?

> Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:490
> +    bool dummy;
> +    decoder >> dummy;

Can you add a comment for future versions of us about what this once was.