[webkit-reviews] review granted: [Bug 134164] Make it possible to override debug preferences on a per-identifier basis as well as globally : [Attachment 233546] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 134164: Make it possible to override debug preferences on a per-identifier
basis as well as globally
https://bugs.webkit.org/show_bug.cgi?id=134164

Attachment 233546: Patch
https://bugs.webkit.org/attachment.cgi?id=233546&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=233546&action=review


> Source/WebKit2/UIProcess/WebPageGroup.cpp:86
> +// FIXME: Why does the WebPreferences object here use “.WebKit2” instead
of “WebKit2.” which all the other constructors use.
> +// If it turns out that it's wrong, we can change it to to “WebKit2.”
and get rid of the globalDebugKeyPrefix from WebPreferences.

Are we using non-ASCII characters in comments now?

> Source/WebKit2/UIProcess/mac/WebPreferencesMac.mm:121
> +#undef INITIALIZE_PREFERENCE_FROM_NSUSERDEFAULTS

Why is this necessary here?