[webkit-reviews] review granted: [Bug 134116] HTMLMediaElement seek algorithm should allow cancelling previous seeks. : [Attachment 233455] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 20 14:28:58 PDT 2014


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 134116: HTMLMediaElement seek algorithm should allow cancelling previous
seeks.
https://bugs.webkit.org/show_bug.cgi?id=134116

Attachment 233455: Patch
https://bugs.webkit.org/attachment.cgi?id=233455&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
> Source/WebCore/html/HTMLMediaElement.h:736
> +    std::unique_ptr<PendingSeek> m_pendingSeek;

Since there can only be one of these, why not have "PendingSeek m_pendingSeek"
so it doesn't need to be allocated each time?


More information about the webkit-reviews mailing list