[webkit-reviews] review granted: [Bug 134084] iOS WebKit2: selection handles become too large when zooming a page. : [Attachment 233398] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 134084: iOS WebKit2: selection handles become too large when zooming a
page.
https://bugs.webkit.org/show_bug.cgi?id=134084

Attachment 233398: Patch
https://bugs.webkit.org/attachment.cgi?id=233398&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=233398&action=review


> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:201
> +    CGFloat inverseScale = 1 / [[self layer] transform].m11;
> +    [_inverseScaleRootView
setTransform:CGAffineTransformMakeScale(inverseScale, inverseScale)];

Can you just call [self _updateUnscaledView]?

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:291
> +	   hitView = [hitView hitTest:[hitView convertPoint:point
fromView:self] withEvent:event];

I would not reuse "hitView" but use a different UIView* local variable for
clarity.

maybe:
for (UIView *subView ...) {
    if (UIView *hitView...)

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1695
>  - (UITextRange *)selectedTextRange

I would store inverseScale in a local variable.

I think this deserve a comment with a little explanation of how the UI works
regarding the caret width/height.