[webkit-reviews] review granted: [Bug 134119] Add copy/move constructors and assignment operators to WTF::Optional : [Attachment 233449] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 134119: Add copy/move constructors and assignment operators to
WTF::Optional
https://bugs.webkit.org/show_bug.cgi?id=134119

Attachment 233449: Patch
https://bugs.webkit.org/attachment.cgi?id=233449&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233449&action=review


r=me with a bug fix:

> Source/WTF/wtf/Optional.h:137
> +	   new (NotNull, std::addressof(m_value)) T(std::forward<U>(u));
> +	   return *this;

Missing "m_isEngaged = true;" here.