[webkit-reviews] review granted: [Bug 134085] [iOS WebKit2] Make -webkit-overflow-scrolling:touch work in iframes (breaks MSWord previews) : [Attachment 233435] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 20 11:30:38 PDT 2014
Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 134085: [iOS WebKit2] Make -webkit-overflow-scrolling:touch work in iframes
(breaks MSWord previews)
https://bugs.webkit.org/show_bug.cgi?id=134085
Attachment 233435: Patch
https://bugs.webkit.org/attachment.cgi?id=233435&action=review
------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233435&action=review
> Source/WebCore/page/scrolling/ScrollingStateTree.cpp:109
> + switch (nodeType) {
this looks ripe for moving into another function, and factoring the appendChild
out, and just cleaning up in general
> Source/WebCore/page/scrolling/ScrollingStateTree.h:85
> + enum SubframeNodeRemoval {
enum class? and drop the "SubframeNodes" suffix? SubframeNodeRemoval::Delete,
SubframeNodeRemoval::Orphan, etc.
More information about the webkit-reviews
mailing list