[webkit-reviews] review granted: [Bug 133579] Refactoring: make MediaTime the primary time type for audiovisual times. : [Attachment 233364] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 20 10:06:02 PDT 2014
Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 133579: Refactoring: make MediaTime the primary time type for audiovisual
times.
https://bugs.webkit.org/show_bug.cgi?id=133579
Attachment 233364: Patch
https://bugs.webkit.org/attachment.cgi?id=233364&action=review
------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233364&action=review
> Source/JavaScriptCore/ChangeLog:15
> + * runtime/JSCJSValue.h:
> + (JSC::jsNumber):
> +
> +2014-06-06 Jer Noble <jer.noble at apple.com>
> +
> + Refactoring: make MediaTime the primary time type for audiovisual
times.
Double entry?
> Source/WTF/ChangeLog:15
> +2014-06-06 Jer Noble <jer.noble at apple.com>
Ditto.
> Source/WebCore/ChangeLog:9
> + In order to limit the number of floating-point rounding errors for
media systems which
> + can make use of rational time objects.
Nit: This should be a complete sentence.
> Source/WebCore/ChangeLog:259
> +2014-06-06 Jer Noble <jer.noble at apple.com>
Another double ChangeLog.
> Source/WebCore/ChangeLog:517
> 2014-06-16 Jer Noble <jer.noble at apple.com>
Is this yet another entry, of is diff just confused?
> Source/WebCore/html/HTMLMediaElement.cpp:1654
> + RefPtr<TextTrackCue> cue = prpCue;
:-O
More information about the webkit-reviews
mailing list