[webkit-reviews] review granted: [Bug 134092] Introduce RenderLayer::offsetFromAncestorLayer() to make convertToLayerCoords() calls with LayoutPoint(0, 0) as parameter more explicit. : [Attachment 233407] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Zalan Bujtas
<zalan at apple.com>'s request for review:
Bug 134092: Introduce RenderLayer::offsetFromAncestorLayer() to make
convertToLayerCoords() calls with LayoutPoint(0, 0) as parameter more explicit.
https://bugs.webkit.org/show_bug.cgi?id=134092

Attachment 233407: Patch
https://bugs.webkit.org/attachment.cgi?id=233407&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233407&action=review


> Source/WebCore/rendering/RenderGeometryMap.cpp:-190
> -//	 fprintf(stderr, "RenderGeometryMap::pushMappingsToAncestor from layer
%p to layer %p, canConvertInLayerTree=%d\n", layer, ancestorLayer,
canConvertInLayerTree);

Lots of commented printfs in this patch.

> Source/WebCore/rendering/RenderLayer.cpp:2026
> +LayoutPoint RenderLayer::offsetFromAncestorLayer(const RenderLayer*
ancestorLayer) const

I think you could call this offsetFromAncestor. Would it make sense to return a
LayoutSize?