[webkit-reviews] review granted: [Bug 134093] [EFL][CMAKE] Disable WebKit1 build as a default : [Attachment 233408] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at webkit.org> has granted Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 134093: [EFL][CMAKE] Disable WebKit1 build as a default
https://bugs.webkit.org/show_bug.cgi?id=134093

Attachment 233408: Patch
https://bugs.webkit.org/attachment.cgi?id=233408&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=233408&action=review


r=me except for my questions.

> Source/cmake/OptionsEfl.cmake:8
> +set(ENABLE_WEBKIT OFF)

Should we keep this flag ?

> Tools/CMakeLists.txt:10
>      add_subdirectory(DumpRenderTree/TestNetscapePlugIn)

ditto