[webkit-reviews] review granted: [Bug 134050]=?UTF-8?Q?=20LayerPool=E2=80=99d=20PlatformCALayerRemote?=/RemoteLayerBackingStore can have stale context pointers : [Attachment 233387] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 134050: LayerPool’d PlatformCALayerRemote/RemoteLayerBackingStore can have
stale context pointers
https://bugs.webkit.org/show_bug.cgi?id=134050

Attachment 233387: patch
https://bugs.webkit.org/attachment.cgi?id=233387&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233387&action=review


> Source/WebCore/platform/graphics/ca/PlatformCALayer.h:228
> +    PassRefPtr<PlatformCALayer> createCompatibleLayerWithSize(LayerType
layerType, PlatformCALayerClient* client, IntSize, UseLayerPool =
UseLayerPool::DoNotUse);

UseLayerPool::DoNotUse hurts.

Why not just have two create methods, one which tries the pool then calls the
other?