[webkit-reviews] review granted: [Bug 133726] [GTK] Limit the amount of API exposed to GObject DOM bindings API : [Attachment 233227] Fix typo in ChangeLog
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 19 13:29:15 PDT 2014
Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 133726: [GTK] Limit the amount of API exposed to GObject DOM bindings API
https://bugs.webkit.org/show_bug.cgi?id=133726
Attachment 233227: Fix typo in ChangeLog
https://bugs.webkit.org/attachment.cgi?id=233227&action=review
------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=233227&action=review
LGTM!
> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:980
> # Insert introspection annotations
> - push(@hBody, "/**\n");
> - push(@hBody, " * ${functionName}:\n");
> - push(@hBody, " * \@self: A #${className}\n");
> + push(@functionHeader, "/**");
> + push(@functionHeader, " * ${functionName}:");
> + push(@functionHeader, " * \@self: A #${className}");
You don't need to provide the newlines anymore?
More information about the webkit-reviews
mailing list