[webkit-reviews] review granted: [Bug 134069] Use a single map for all callback types in WebPageProxy : [Attachment 233373] Part 1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 19 12:44:53 PDT 2014
Anders Carlsson <andersca at apple.com> has granted mitz at webkit.org
<mitz at webkit.org>'s request for review:
Bug 134069: Use a single map for all callback types in WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=134069
Attachment 233373: Part 1
https://bugs.webkit.org/attachment.cgi?id=233373&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233373&action=review
> Source/WebKit2/UIProcess/GenericCallback.h:170
> + void put(PassRefPtr<CallbackBase> callback)
I think set or add would be better than put but I don't feel strongly about it.
More information about the webkit-reviews
mailing list