[webkit-reviews] review granted: [Bug 133934] Subtrees with :first-child and :last-child are not invalidated when siblings are added/removed : [Attachment 233191] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 18 14:46:16 PDT 2014


Antti Koivisto <koivisto at iki.fi> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 133934: Subtrees with :first-child and :last-child are not invalidated when
siblings are added/removed
https://bugs.webkit.org/show_bug.cgi?id=133934

Attachment 233191: Patch
https://bugs.webkit.org/attachment.cgi?id=233191&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=233191&action=review


> Source/WebCore/dom/Element.cpp:1597
> +	       if (!style || style->lastChildState())

I'm still slightly worried we are invalidating more in display:none case.
However maybe this doesn't have much real world significance.


More information about the webkit-reviews mailing list