[webkit-reviews] review granted: [Bug 133991] REGRESSION (r167856): Unable to log into HSBC app : [Attachment 233250] Patch and layout tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 18 14:32:42 PDT 2014


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 133991: REGRESSION (r167856): Unable to log into HSBC app
https://bugs.webkit.org/show_bug.cgi?id=133991

Attachment 233250: Patch and layout tests
https://bugs.webkit.org/attachment.cgi?id=233250&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=233250&action=review


r=me

>
LayoutTests/fast/loader/allow-redirect-to-invalid-url-using-javascript-expected
.txt:11
> +Note, this test must be run in Dump Render Tree.

Nit: Usually we just say "DumpRenderTree".  If you change it here, please
change it in all the tests and expected results.


More information about the webkit-reviews mailing list