[webkit-reviews] review granted: [Bug 130913] Web Inspector: AXI: expose aria-relevant : [Attachment 233282] patch with review feedback

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 18 11:05:40 PDT 2014

Joseph Pecoraro <joepeck at webkit.org> has granted James Craig
<jcraig at apple.com>'s request for review:
Bug 130913: Web Inspector: AXI: expose aria-relevant

Attachment 233282: patch with review feedback

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=233282&action=review

Awesome! r=me

> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:402
> +			   // Token values: No need to localize the string

I don't think this comment is needed.

> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:406
> +		       if (accessibilityProperties.liveRegionAtomic === true) {

Nit: No need for the "=== true" (I realize this is old code)

More information about the webkit-reviews mailing list