[webkit-reviews] review denied: [Bug 134015] add ftl infrastructure to windows : [Attachment 233288] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 134015: add ftl infrastructure to windows
https://bugs.webkit.org/show_bug.cgi?id=134015

Attachment 233288: Patch
https://bugs.webkit.org/attachment.cgi?id=233288&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233288&action=review


> Source/JavaScriptCore/disassembler/LLVMDisassembler.cpp:57
> +	   _snprintf(

Can we have one common #define or something in WTF so that we don't have to #if
PLATFORM in so many places just for this function?

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:1439
> +			   right, m_out.constDouble(std::nan("")))));

We should use PNaN here. It's a JSC thing.