[webkit-reviews] review granted: [Bug 134004] [iOS][wk2] Ensure that layers are marked volatile before allowing the process to suspend : [Attachment 233271] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 134004: [iOS][wk2] Ensure that layers are marked volatile before allowing
the process to suspend
https://bugs.webkit.org/show_bug.cgi?id=134004

Attachment 233271: patch
https://bugs.webkit.org/attachment.cgi?id=233271&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233271&action=review


> Source/WebKit2/Shared/mac/RemoteLayerBackingStoreCollection.h:65
> +    bool markBackingStoreVolatileImmediately(RemoteLayerBackingStore&,
unsigned volatilityMarkingFlags = 0);

enum for the set of flag mask please, not unsigned.

> Source/WebKit2/Shared/mac/RemoteLayerBackingStoreCollection.mm:160
> +    for (const auto& backingStore : m_unparentedBackingStore)

Blank line above please.

> Source/WebKit2/UIProcess/ios/ProcessThrottler.mm:109
> +    // If the process is currently waiting for the WebProcess to become
suspendable but would become runnable,
> +    // let it know that it can cancel the suspension cleanup.

Hard to grok