[webkit-reviews] review granted: [Bug 128301] Misused PLATFORM(MIDDLE_ENDIAN) and PLATFORM(BIG_ENDIAN) : [Attachment 223320] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 17 14:59:18 PDT 2014
Daniel Bates <dbates at webkit.org> has granted Tamas Gergely
<tgergely.u-szeged at partner.samsung.com>'s request for review:
Bug 128301: Misused PLATFORM(MIDDLE_ENDIAN) and PLATFORM(BIG_ENDIAN)
https://bugs.webkit.org/show_bug.cgi?id=128301
Attachment 223320: patch
https://bugs.webkit.org/attachment.cgi?id=223320&action=review
------- Additional Comments from Daniel Bates <dbates at webkit.org>
r=me
Is there any way we can prevent this? From briefly searching, GCC has option
-Wundef to warn about undefined identifiers. Would enabling it lead to many
false positives?
More information about the webkit-reviews
mailing list