[webkit-reviews] review granted: [Bug 133965] Web Inspector: style declaration editor: visual highlight doesn't match actual selected text : [Attachment 233257] [PATCH] Attempted CSS fix, remembered ChangeLog VER 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 17 13:42:51 PDT 2014


Joseph Pecoraro <joepeck at webkit.org> has granted Jono Wells
<jonowells at apple.com>'s request for review:
Bug 133965: Web Inspector: style declaration editor: visual highlight doesn't
match actual selected text
https://bugs.webkit.org/show_bug.cgi?id=133965

Attachment 233257: [PATCH] Attempted CSS fix, remembered ChangeLog VER 2
https://bugs.webkit.org/attachment.cgi?id=233257&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=233257&action=review


r=me

>
Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.css:55
>      /* Compensate for the missing checkboxes so properties line up with
editable styles that have checkboxes. */

Can this comment be removed now? Essentially we are just removing the indent.
In fact the comment may be more useful up above where we do set a text-indent.


More information about the webkit-reviews mailing list