[webkit-reviews] review granted: [Bug 133942] [UI-side compositing] fix reflections on composited layers : [Attachment 233236] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 133942: [UI-side compositing] fix reflections on composited layers
https://bugs.webkit.org/show_bug.cgi?id=133942

Attachment 233236: Patch
https://bugs.webkit.org/attachment.cgi?id=233236&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233236&action=review


> Source/WebCore/ChangeLog:12
> +	   This layer may be told that its content need updating out of order
during

contents

> Source/WebCore/ChangeLog:16
> +	   In the UI process, a new step is added to
emoteLayerTreeHost::updateLayerTree()

*Re*mote

> Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:330
> +    CALayer* caLayer = layer->m_layer.get();

star on the wrong side. isn't there a platformLayer getter, too?

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:201
> +	   m_context->layerPropertyChangedInTransactionBuilding(this);

WhileBuildingTransaction?