[webkit-reviews] review granted: [Bug 133967] [ftlopt] Fold constant Phis : [Attachment 233213] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 133967: [ftlopt] Fold constant Phis
https://bugs.webkit.org/show_bug.cgi?id=133967

Attachment 233213: the patch
https://bugs.webkit.org/attachment.cgi?id=233213&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233213&action=review


r=me

> Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.h:136
> +    // This method is evil - it causes a huge maintenance headache and there
is a gross amount of
> +    // code devoted to it. It would be much nicer to just always run the
constant folder on each
> +    // block. But, the last time we did it, it was a 1% SunSpider
regression:
> +    // https://bugs.webkit.org/show_bug.cgi?id=133947
> +    // So, we should probably keep this method.

I might be willing to eat 1% for this -- particularly if the overall effect on
JetStream is less than 1%.