[webkit-reviews] review requested: [Bug 130941] [ATK] No accessible caret-moved events in a href display:block in div : [Attachment 233237] fix caret in a block, v1.00

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 17 10:07:11 PDT 2014


Jarek Czekalski <jarekczek at poczta.onet.pl> has asked  for review:
Bug 130941: [ATK] No accessible caret-moved events in a href display:block in
div
https://bugs.webkit.org/show_bug.cgi?id=130941

Attachment 233237: fix caret in a block, v1.00
https://bugs.webkit.org/attachment.cgi?id=233237&action=review

------- Additional Comments from Jarek Czekalski <jarekczek at poczta.onet.pl>
Hello again, Mario!

I'm attaching another short patch. Please consider whether the suggested
solution is correct.

It would be cleaner to use renderer()->isBlock instead of
!renderer()->isInline(), but only the latter syntax may be easily merged into
stable branch.

After this patch yelp title page becomes accessible in webkit1. I'm planning to
ask for stable branch merge for this patch, which should be applied after:
1. Bug #132527
2. the hot fix for the above patch (contained in the ticket)
3. Bug #132349
4. Bug #130941 (the one here)

These patches apply almost cleanly to the stable branch, a small adjustment is
needed for the first one.

Thanks in advance for the review.


More information about the webkit-reviews mailing list