[webkit-reviews] review denied: [Bug 133524] [iOS] Input type=time elements styled with SVG fonts have 0 width : [Attachment 233097] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 16 12:47:57 PDT 2014
Simon Fraser (smfr) <simon.fraser at apple.com> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 133524: [iOS] Input type=time elements styled with SVG fonts have 0 width
https://bugs.webkit.org/show_bug.cgi?id=133524
Attachment 233097: Patch
https://bugs.webkit.org/attachment.cgi?id=233097&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233097&action=review
> Source/WebCore/platform/text/ios/LocalizedDateCache.mm:96
> + if (m_font == font && m_maxWidthMap.contains(key)) {
> + cachedResult = m_maxWidthMap.get(key);
> + return Vector<String>();
> + }
This conflation of caching max widths per type (globally)? and the getting of
list of strings is super confusing, and I don't understand the global per-type
cache.
More information about the webkit-reviews
mailing list