[webkit-reviews] review granted: [Bug 133913] CSS JIT: add support for the :lang() pseudo class : [Attachment 233120] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 15 00:27:50 PDT 2014

Andreas Kling <akling at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 133913: CSS JIT: add support for the :lang() pseudo class

Attachment 233120: Patch

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233120&action=review


> Source/WebCore/css/SelectorCheckerTestFunctions.h:118
> +    if (value.startsWith(String(*filter), false)) {

String(*filter) will ref() and unref() the StringImpl here, you can do better.

More information about the webkit-reviews mailing list