[webkit-reviews] review denied: [Bug 133908] Some classes with virtual methods are missing virtual destructors : [Attachment 233115] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 14 17:35:35 PDT 2014


Anders Carlsson <andersca at apple.com> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 133908: Some classes with virtual methods are missing virtual destructors
https://bugs.webkit.org/show_bug.cgi?id=133908

Attachment 233115: Patch
https://bugs.webkit.org/attachment.cgi?id=233115&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
I don't think this warning is useful. Nobody deletes a
TextureMapperPlatformLayer::Client for example, so this just creates extra
vtable entries for no good reason.


More information about the webkit-reviews mailing list