[webkit-reviews] review granted: [Bug 133898] Store DOM constants directly in the JS object rather than jumping through a custom accessor : [Attachment 233105] Patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 133898: Store DOM constants directly in the JS object rather than jumping
through a custom accessor
https://bugs.webkit.org/show_bug.cgi?id=133898

Attachment 233105: Patch
https://bugs.webkit.org/attachment.cgi?id=233105&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233105&action=review


>>> Source/WebCore/bindings/scripts/test/TestObj.idl:-248
>>> -	 const DOMString CONST_VALUE_10 = "my constant string";
>> 
>> Why did we remove this? Do we just not have any non-integer constants in the
dom?
> 
> We both don't have any non-integer constants, and the WebIDL spec says it
shouldn't be supported.

Well, I guess i'll let this change happen (but just this once) ;D