[webkit-reviews] review granted: [Bug 133892] Masks disappear when layers become tiled : [Attachment 233099] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 13 21:13:35 PDT 2014


Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 133892: Masks disappear when layers become tiled
https://bugs.webkit.org/show_bug.cgi?id=133892

Attachment 233099: Patch
https://bugs.webkit.org/attachment.cgi?id=233099&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233099&action=review


> Source/WebCore/ChangeLog:9
> +	   There were several problems with tiled mask layers.

Nice!

> Source/WebCore/ChangeLog:22
> +	       1. setting a bit on a layer to note that it's being used as a
maks.

typo "maks"

> LayoutTests/compositing/masks/become-tiled-mask.html:35
> +    if (window.testRunner)

indentation of this script is wacky (some 2-space, some 4)


More information about the webkit-reviews mailing list