[webkit-reviews] review denied: [Bug 133832] Parser statementDepth accounting needs to account for when a function body excludes its braces : [Attachment 233033] patch 2: fixed tests so that they are more expressive, and can detect the issue in this bug. Still need to look into the JSRegress perf issue.

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 133832: Parser statementDepth accounting needs to account for when a
function body excludes its braces
https://bugs.webkit.org/show_bug.cgi?id=133832

Attachment 233033: patch 2: fixed tests so that they are more expressive, and
can detect the issue in this bug.  Still need to look into the JSRegress perf
issue.
https://bugs.webkit.org/attachment.cgi?id=233033&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233033&action=review


r- due to tests and apparent perf issue

> Source/JavaScriptCore/parser/Parser.cpp:1129
> +	   failIfFalseIfStrict(m_statementDepth == 1, "In strict mode,
functions may only be declared at top level or immediately within another
function");

"Strict mode does not allow function declarations in a lexically nested
statement"

> LayoutTests/ChangeLog:4
> +	   Parser statementDepth accounting needs to account for when a
function body excludes its braces.
> +	   <https://webkit.org/b/133832>

Please do the rephrasing in a second patch as it's currently obscuring your
meaningful tests invalid vs. valid is fine in our other tests so this
rephrasing isn't critical to this patch.