[webkit-reviews] review granted: [Bug 133863] [iOS] Networking process always decodes keys : [Attachment 233058] Disallow decoding keys by default

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted mitz at webkit.org
<mitz at webkit.org>'s request for review:
Bug 133863: [iOS] Networking process always decodes keys
https://bugs.webkit.org/show_bug.cgi?id=133863

Attachment 233058: Disallow decoding keys by default
https://bugs.webkit.org/attachment.cgi?id=233058&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233058&action=review


r=me with the naming change we discussed.

> Source/WebKit2/Shared/cf/ArgumentCodersCF.cpp:649
> +    if (keyDecodingAllowed)
> +	   SecKeyFindWithPersistentRef(keyData.get(), &key);

Will this do the right thing if key decoding is disallowed? Shouldn't it just
return false in that case?