[webkit-reviews] review granted: [Bug 133512] [ATK] Missing 'selection-changed' signal when navigating a combo box with keyboard : [Attachment 233052] Path proposal

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Mario Sanchez Prada
<mario at webkit.org>'s request for review:
Bug 133512: [ATK] Missing 'selection-changed' signal when navigating a combo
box with keyboard
https://bugs.webkit.org/show_bug.cgi?id=133512

Attachment 233052: Path proposal
https://bugs.webkit.org/attachment.cgi?id=233052&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233052&action=review


> Source/WebCore/ChangeLog:9
> +	   option when it changes, which will send a platform-dependant

platform-dependEnt

> Source/WebCore/rendering/RenderMenuList.cpp:439
> +    if (AccessibilityMenuList* menuList =
toAccessibilityMenuList(document().axObjectCache()->get(this)))

we should do a check here
if (AXObjectCache* cache = document()->existingAXObjectCache()) {

}