[webkit-reviews] review granted: [Bug 133841] [EFL][WK2] Change ewk_view_settings_get to ewk_page_group_settings_get : [Attachment 233030] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 13 07:20:57 PDT 2014


Gyuyoung Kim <gyuyoung.kim at webkit.org> has granted Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 133841: [EFL][WK2] Change ewk_view_settings_get to
ewk_page_group_settings_get
https://bugs.webkit.org/show_bug.cgi?id=133841

Attachment 233030: Patch
https://bugs.webkit.org/attachment.cgi?id=233030&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=233030&action=review


I don't have big opinion about this change. However, it looks there is no
critical issue.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_page_group.cpp:62
> +

Nit: unnecessary line.


More information about the webkit-reviews mailing list