[webkit-reviews] review granted: [Bug 131732] [CSS Grid Layout] Introduce an explicit type for resolved grid positions : [Attachment 232989] Patch

[bugzilla-daemon at webkit.org]

Sergio Villar Senin <svillar at igalia.com> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 131732: [CSS Grid Layout] Introduce an explicit type for resolved grid
positions
https://bugs.webkit.org/show_bug.cgi?id=131732

Attachment 232989: Patch
https://bugs.webkit.org/attachment.cgi?id=232989&action=review

------- Additional Comments from Sergio Villar Senin <svillar at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232989&action=review


OK good figures. Let's get this in. 

I have a couple of nits that should be fixed before landing. Also check the EFL
build failure.

> Source/WebCore/rendering/style/GridResolvedPosition.cpp:50
> +

Let's remove these two, they don't have anything to do with a resolved
position, they just access the style.

> Source/WebCore/rendering/style/GridResolvedPosition.h:87
> +

Remove the resolvedOppositePosition argument name in these four. I guess it's
obvious from the function name.