[webkit-reviews] review granted: [Bug 130688] Add support for thread/WorkQueue QoS : [Attachment 233012] Fix

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 130688: Add support for thread/WorkQueue QoS
https://bugs.webkit.org/show_bug.cgi?id=130688

Attachment 233012: Fix
https://bugs.webkit.org/attachment.cgi?id=233012&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233012&action=review


> Source/WebKit2/Platform/mac/WorkQueueMac.cpp:48
> +static dispatch_qos_class_t platformQOS(WorkQueue::QOS qos)

I'd call this dispatchQOSClass instead.

> Source/WebKit2/Platform/mac/WorkQueueMac.cpp:60
> +    default:
> +	   return QOS_CLASS_DEFAULT;

Please move this return out of the switch statement and add an
ASSERT_NOT_REACHED() before it.