[webkit-reviews] review granted: [Bug 133819] Convert TileController and TileGrid from ObjC to C++ : [Attachment 232994] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 133819: Convert TileController and TileGrid from ObjC to C++
https://bugs.webkit.org/show_bug.cgi?id=133819

Attachment 232994: Patch
https://bugs.webkit.org/attachment.cgi?id=232994&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232994&action=review


> Source/WebCore/platform/graphics/ca/mac/TileController.cpp:386
> +	   FloatRect visiblePart(CGRectOffset([tileLayer frame],
tileTranslation.x(), tileTranslation.y()));

looks like ObjC to me!

> Source/WebCore/platform/graphics/ca/mac/TileController.cpp:386
> -	   FloatRect visiblePart(CGRectOffset([tileLayer frame],
tileTranslation.x(), tileTranslation.y()));
> +	   FloatRect visiblePart(CGRectOffset(frameForLayer(tileLayer),
tileTranslation.x(), tileTranslation.y()));

wut. weird patch format, I guess?

> Source/WebCore/platform/graphics/mac/WebLayer.h:31
> +#include <WebCore/FloatRect.h>

we're in webcore, is there any need for WebCore/?