[webkit-reviews] review granted: [Bug 133780] [GTK] Performance tests should be always ran with WKTR : [Attachment 232926] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 11 22:13:18 PDT 2014


Ryosuke Niwa <rniwa at webkit.org> has granted Carlos Alberto Lopez Perez
<clopez at igalia.com>'s request for review:
Bug 133780: [GTK] Performance tests should be always ran with WKTR
https://bugs.webkit.org/show_bug.cgi?id=133780

Attachment 232926: Patch
https://bugs.webkit.org/attachment.cgi?id=232926&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=232926&action=review


> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:71
> +	   # The GTK+ port only supports WebKit2, so it always uses WKTR.
> +	   if self._port.name().startswith("gtk"):
> +	       self._options.webkit_test_runner = True

Should we split out some warning about this?


More information about the webkit-reviews mailing list