[webkit-reviews] review granted: [Bug 133770] WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it : [Attachment 232910] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 133770: WTR cleanup: push per-test viewport configuration into
TestController, where platforms can customize it
https://bugs.webkit.org/show_bug.cgi?id=133770

Attachment 232910: Patch
https://bugs.webkit.org/attachment.cgi?id=232910&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232910&action=review


> Tools/WebKitTestRunner/ios/TestControllerIOS.mm:72
> +    if (shouldMakeViewportFlexible(test.pathOrURL())) {

Early return?

> Tools/WebKitTestRunner/mac/TestControllerMac.mm:89
> +    WKRetainPtr<WKMutableDictionaryRef> viewOptions =
adoptWK(WKMutableDictionaryCreate());
> +    WKRetainPtr<WKStringRef> useThreadedScrollingKey =
adoptWK(WKStringCreateWithUTF8CString("ThreadedScrolling"));
> +    WKRetainPtr<WKBooleanRef> useThreadedScrollingValue =
adoptWK(WKBooleanCreate(shouldUseThreadedScrolling(test.pathOrURL())));
> +    WKDictionarySetItem(viewOptions.get(), useThreadedScrollingKey.get(),
useThreadedScrollingValue.get());
> +
> +    WKRetainPtr<WKStringRef> useRemoteLayerTreeKey =
adoptWK(WKStringCreateWithUTF8CString("RemoteLayerTree"));
> +    WKRetainPtr<WKBooleanRef> useRemoteLayerTreeValue =
adoptWK(WKBooleanCreate(shouldUseRemoteLayerTree()));

These can all be auto.