[webkit-reviews] review granted: [Bug 133766] Implement swipeWithEvent for non-fluid swipes : [Attachment 232904] patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 133766: Implement swipeWithEvent for non-fluid swipes
https://bugs.webkit.org/show_bug.cgi?id=133766

Attachment 232904: patch
https://bugs.webkit.org/attachment.cgi?id=232904&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232904&action=review


> Source/WebKit2/UIProcess/API/mac/WKView.mm:1188
> +    if ([self shouldIgnoreMouseEvents])
> +	   return;
> +
> +    if (!_data->_allowsBackForwardNavigationGestures)
> +	   return;
> +
> +    if ([event deltaX] > 0.0)
> +	   _data->_page->goBack();
> +    else if ([event deltaX] < 0.0)
> +	   _data->_page->goForward();

Dot syntax.

Should we call super if we can't swipe?