[webkit-reviews] review denied: [Bug 133562] Add SPI for Injected Bundle to provide user agent for a given URL : [Attachment 232869] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 11 14:07:34 PDT 2014

Anders Carlsson <andersca at apple.com> has denied Grant Kennell
<gkennell at apple.com>'s request for review:
Bug 133562: Add SPI for Injected Bundle to provide user agent for a given URL

Attachment 232869: patch

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232869&action=review

Looks good overall! I think you need to rebase the patch against ToT and
address my review comments.

> Source/WebKit2/ChangeLog:435
> +2014-06-05  Grant Kennell  <gkennell at apple.com>

This entry should be moved to the top of the ChangeLog.

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h:409

> +    WKBundlePageUserAgentForURLCallback				      
>  } WKBundlePageLoaderClientV7;

I think you need to add a new struct version here.

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h:467

> +    WKBundlePageUserAgentForURLCallback				      
>  } WKBundlePageLoaderClient WK_DEPRECATED("Use an explicit versioned struct

You don't need to add this to the deprecated client.


> +    WKStringRef userAgent = m_client.userAgentForURL(toAPI(frame),
toAPI(url.get()), m_client.base.clientInfo);

This needs to go into a WKRetainPtr or it will be leaked.

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:103

> +    API::String* userAgentForURL(WebFrame*, API::String*);

I think this should return a RefPtr<API::String>

More information about the webkit-reviews mailing list