[webkit-reviews] review granted: [Bug 133747] [EME][Mac] Propagate errors from AVSampleBufferDisplayLayer through to MSE : [Attachment 232885] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 11 12:37:40 PDT 2014


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 133747: [EME][Mac] Propagate errors from AVSampleBufferDisplayLayer through
to MSE
https://bugs.webkit.org/show_bug.cgi?id=133747

Attachment 232885: Patch
https://bugs.webkit.org/attachment.cgi?id=232885&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232885&action=review


>
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC
.mm:68
> +{
> +    m_parent->unregisterForErrorNotifications(this);
>  }

Is it worth NULLing m_client here?


More information about the webkit-reviews mailing list