[webkit-reviews] review denied: [Bug 133546] [JavaScriptCore] FTL buildfix for EFL platform : [Attachment 232856] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 11 08:09:30 PDT 2014

Filip Pizlo <fpizlo at apple.com> has denied László Langó
<llango.u-szeged at partner.samsung.com>'s request for review:
Bug 133546: [JavaScriptCore] FTL buildfix for EFL platform

Attachment 232856: Patch

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232856&action=review

> Source/JavaScriptCore/llvm/InitializeLLVMPOSIX.cpp:66
> +#pragma GCC diagnostic ignored "-Wmissing-format-attribute"

I think you should add the format attribute that it is asking for. Have you
tried it?  Also, it would be useful to post the compiler error you're getting
so that others could suggest a better fix. In general using pragmas to disable
warnings is not an OK way of fixing compiler warnings.

More information about the webkit-reviews mailing list