[webkit-reviews] review granted: [Bug 133715] [EFL][WK2] Add missing test cases for EWK2ViewTest : [Attachment 232858] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at webkit.org> has granted Shivakumar J M
<shiva.jm at samsung.com>'s request for review:
Bug 133715: [EFL][WK2] Add missing test cases for EWK2ViewTest
https://bugs.webkit.org/show_bug.cgi?id=133715

Attachment 232858: Patch
https://bugs.webkit.org/attachment.cgi?id=232858&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=232858&action=review


LGTM except for minor nits.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:414
> +

Unnecessary line.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:1052
> +    EXPECT_FALSE(ewk_view_page_contents_get(webView(),
(Ewk_Page_Contents_Type) 2, PageContentsAsStringCallback, 0));

Use static_cast<Ewk_Page_Contents_Type> instead of (Ewk_Page_Contents_Type).