[webkit-reviews] review granted: [Bug 133702] [iOS][WK2] ScrollingTreeOverflowScrollingNode does not use asynchronous touch dispatch : [Attachment 232822] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 10 16:49:54 PDT 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 133702: [iOS][WK2] ScrollingTreeOverflowScrollingNode does not use
asynchronous touch dispatch
https://bugs.webkit.org/show_bug.cgi?id=133702

Attachment 232822: Patch
https://bugs.webkit.org/attachment.cgi?id=232822&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232822&action=review


>
Source/WebKit2/UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h:
48
> +

Extra line.

> Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:533
> +    [m_contentView willStartPanOrPinchGesture];

The name of the content view method doesn't communicate that it might be some
inner UIScrollView that will begin a pan or pinch, so perhaps it needs a better
name.


More information about the webkit-reviews mailing list