[webkit-reviews] review granted: [Bug 133690] Factor repeated CFRunLoopObserver code out : [Attachment 232805] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 10 14:50:46 PDT 2014

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 133690: Factor repeated CFRunLoopObserver code out

Attachment 232805: patch

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232805&action=review

> Source/WebCore/platform/cf/RunLoopObserver.h:39
> +    typedef std::function<void ()> RunLoopObserverCallback;

Maybe the callback should take a RunLoopObserver&?

More information about the webkit-reviews mailing list