[webkit-reviews] review granted: [Bug 133689] Add -[WKWebView evaluateJavaScript:completionHandler:] : [Attachment 232804] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 10 14:16:37 PDT 2014


Geoffrey Garen <ggaren at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 133689: Add -[WKWebView evaluateJavaScript:completionHandler:]
https://bugs.webkit.org/show_bug.cgi?id=133689

Attachment 232804: Patch
https://bugs.webkit.org/attachment.cgi?id=232804&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=232804&action=review


r=me

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:495
> +		   // We don't want to call the block from within the call that
invalidates the web view,
> +		   // so defer it here.

Why not?


More information about the webkit-reviews mailing list